Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github status upgrade #3717

Merged
merged 4 commits into from Oct 28, 2014
Merged

Conversation

jenshnielsen
Copy link
Member

This PR does a number of things related to the github stats generation. The main aim is to silence the related warning in the docs build.

  1. Upgrade to lates version of github_stats.py from IPython. We have always been using a copy. This has a number of advantages. Use Oauth to login to github to avoid the api rate limiter. Optional caching of requests etc.
  2. Modify this to match the behaviour in the existing matplotlib script. i.e. Add header, change default project to matplotlib/matplotlib and add a note about where the script is coming from.
  3. Change escaped sequences in the github output. This escapes all ` _ and *'s in the output. Some of them could be interpreted as rst markup. However, I could not find a way of doing that reliably.
  4. Regenerate the github stats with the new script.

@tacaswell tacaswell added this to the v1.5.x milestone Oct 26, 2014
@jenshnielsen
Copy link
Member Author

Any comments on this? We can also go for a minimal change and just fix the RST syntax errors in the output rather than the full replacement, but I kept getting rate limiting errors from github with the old version due to the anonymous login.

tacaswell added a commit that referenced this pull request Oct 28, 2014
@tacaswell tacaswell merged commit 537499b into matplotlib:master Oct 28, 2014
@jenshnielsen jenshnielsen deleted the github_status_upgrade branch October 28, 2014 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants