Complete removal of PyCXX #3723
Conversation
|
It looks good to me. I did a quick test locally and everything seems to work fine. 👍 on merging this from me. |
MNT : Complete removal of PyCXX
| segs[i] = Py::asObject((PyObject*)py_line); | ||
| if (PyList_SetItem(segs, i, (PyObject*)py_line)) { | ||
| PyErr_SetString(PyExc_RuntimeError, | ||
| "Unable to set contour segments"); |
There was a problem hiding this comment.
I think you need to Py_DECREF(segs) here.
|
Thanks for doing this! I appreciate how much work this was. Sorry about commenting after this was merged, but it looks like this was up for less than 24 hours! |
|
Sorry, I applied the logic of the other pycxx branch and merged it on trusting the test suite. |
|
@tacaswell: No problem. It's more important that this works than anything else, so merging early is the best for that. |
|
@tacaswell: What should I do now that this PR has been merged? Should I just write a new PR for the changes and refer back to this one? |
|
Yes, that is probably the best way On Mon, Oct 27, 2014 at 3:06 PM, Ian Thomas notifications@github.com
Thomas Caswell |
Final decxx corrections to PR #3723
This PR completes the removal of PyCXX from matplotlib following on from PR #3646.
There are 2 commits. The first converts the _tri module, the last module to use PyCXX, to use the Python/C API instead. I've followed the lead of #3646 so that we have some code consistency in terms of separate wrapper files, code layout, use of the same exception-catching macros, etc.
The second commit removes the PyCXX source code, the relevant sections of the setup scripts, and a few other places where it was mentioned.
It is always nice to write a PR that is such a net reduction in code!