Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT : delete unused Image #3765

Merged
merged 1 commit into from Nov 7, 2014

Conversation

tacaswell
Copy link
Member

We only import Image to see if PIL/pillow is available to decide
if we should register jpg/tiff support for FigureCanvasBase.

Technically an API break, but anyone who was relying on this
probably deserves what they get.

@tacaswell tacaswell added this to the v1.5.x milestone Nov 7, 2014
@tacaswell tacaswell changed the title MNT : delete used Image MNT : delete unused Image Nov 7, 2014
@tacaswell
Copy link
Member Author

Gah, I can't type, and that commit message is totally wrong....going to fix using amend and force-push...

We only import Image to see if PIL/pillow is available to decide
if we should register jpg/tiff support for FigureCanvasBase.

Technically an API break, but anyone who was relying on this
probably deserves what they get.
@WeatherGod
Copy link
Member

Oddly enough, this file doesn't seem to have an __all__, which might have
been helpful to mitigate this.

On Fri, Nov 7, 2014 at 4:13 PM, Thomas A Caswell notifications@github.com
wrote:

Gah, I can't type, and that commit message is totally wrong....going to
fix using amend and force-push...


Reply to this email directly or view it on GitHub
#3765 (comment)
.

efiring added a commit that referenced this pull request Nov 7, 2014
@efiring efiring merged commit 18a7ef3 into matplotlib:master Nov 7, 2014
@tacaswell tacaswell deleted the removed_unused_import branch December 31, 2014 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants