BUG : fix #3805 #3808
Merged
BUG : fix #3805 #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enusure that norm.v{min,max} are not `None` before expanding
them to ensure that 0 < vmax-vmin.
|
You beat me to it! That's the fix; does it need a test? |
|
writing it right now, |
|
Looks good to me apart from the pep8 issue on Travis in the test. (I am not sure that pep8 on the tests makes that much sense but I guess it is easy to fix in this case) |
tacaswell
force-pushed
the
colorbar_norm_bug
branch
from
512b4a8
to
661db3f
Compare
|
fixed + force pushed. Sorry had my editor configured wrong. |
|
Should this be backported? |
efiring
added a commit
that referenced
this pull request
Nov 16, 2014
|
back-ported as 7ba2c2a Good catch! I actually made the change against 1.4.2, but targeted the PR against the wrong branch..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enusure that norm.v{min,max} are not
Nonebefore expandingthem to ensure that 0 < vmax-vmin.