Path.contains_points() returns a uint8 array instead of a bool array #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this. It works as intended in 1.4.2 so it seems likely to be a result of the c++ refactor. |
|
Fix attached. |
mdboom
force-pushed
the
contains-bool
branch
from
3c4145b
to
2c1bc6b
Compare
| } | ||
| } | ||
| inside_flag[i] |= subpath_flag[i]; | ||
| if (inside_flag[i] == 0) { | ||
| inside_flag[i] = inside_flag[i] || subpath_flag[i]; |
There was a problem hiding this comment.
Was this one necessary? (Don't change it, I'm just curious)
There was a problem hiding this comment.
In C++ the | operator is not valid on bool, and ||= does not exist. So AFAICT, you have to do something like this.
pelson
added a commit
that referenced
this pull request
Nov 21, 2014
Path.contains_points() returns a uint8 array instead of a bool array
|
👍 - swift @mdboom. Thanks for reporting @alimuldal. It's not often a bug goes from reported to merged in < 2 hours 😉 |
|
Awesome, thanks guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs,
matplotlib.path.Path.contains_points()ought to return a boolean array, but it currently returns a uint8 array. It looks like this API change was introduced in ba40160. It caught me out when I tried to use the result ofcontains_points()as a boolean index to another array.