Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix units examples under python3 #3838

Merged
merged 2 commits into from Oct 20, 2015
Merged

Fix units examples under python3 #3838

merged 2 commits into from Oct 20, 2015

Conversation

jenshnielsen
Copy link
Member

Seems like passing additional arguments to object.new is no longer supported. AFAIK these would previously just have been dropped anyway so I have removed them but I would like some input from someone who understands the python metaclasses better than me.

@jenshnielsen
Copy link
Member Author

Added a change to make sure the the whole multiplies of pi are rendered as integers in python3 as in python2 by doing integer division.

With this change the result of running the examples with python3 looks identical to what is in the current docs.

@tacaswell tacaswell added this to the v1.5.x milestone Nov 24, 2014
@tacaswell
Copy link
Member

Reading this I am not convinced that this is the proper use of overloading __new__ in any case.

@tacaswell tacaswell modified the milestones: proposed next point release, next point release Feb 19, 2015
@tacaswell
Copy link
Member

@jenshnielsen How do you exercise the problem?

@jenshnielsen
Copy link
Member Author

I was trying to build the docs with python3. That mostly works apart from the unit examples and
an issue with loading saved data, which is not really a matplotlib issue but either a numpy or a python issue.

I agree that this is not really the right solution but I haven't had the time to dive into fixing this probably.

This is no worse off than it was in the latest release (docs build has never fully worked with python3 as far as I know) so I don't think it needs to be blocker for the next release.

@tacaswell tacaswell modified the milestones: next point release, proposed next point release Jul 17, 2015
@jenshnielsen jenshnielsen mentioned this pull request Jul 27, 2015
Closed
@jenshnielsen jenshnielsen mentioned this pull request Oct 20, 2015
Closed
mdboom added a commit that referenced this pull request Oct 20, 2015
@mdboom
Merge pull request #3838 from jenshnielsen/units_examples_python3
a9a523f 
Fix units examples under python3
@mdboom mdboom merged commit a9a523f into matplotlib:master Oct 20, 2015
mdboom added a commit that referenced this pull request Oct 20, 2015
@mdboom
Merge pull request #3838 from jenshnielsen/units_examples_python3
72c2503 
Fix units examples under python3
@mdboom
Copy link
Member

mdboom commented Oct 20, 2015

Backported to v1.5.x in 72c2503

@mdboom mdboom modified the milestones: next point release (1.5.0), proposed next point release (2.1) Oct 20, 2015
@jenshnielsen jenshnielsen deleted the units_examples_python3 branch November 9, 2015 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jenshnielsen @tacaswell @mdboom