Legend deprecate removal + cleanup #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer accept positional pos value
use descriptive name in generator rather than `_` even if it is going to be dropped
If both handle and labels were passed to Axes.legend they would both be discarded in favor of the auto-generated handles/labels. Also added a warning that if mixed positional/keyword arguments are used (something is going to be ignored).
|
|
||
| warn.assert_called_with("You have mixed positional and keyword " | ||
| "arguments, some input will be " | ||
| "be discarded.") |
|
looks good to me. |
WeatherGod
added a commit
that referenced
this pull request
Dec 30, 2014
Legend deprecate removal + cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.