Add Support for `scroll_event` in WebAgg and NbAgg [backport to 1.4.x] #3968

blink1073 · 2015-01-04T22:53:30Z

Attached a scroll event handler to canvas_div and added the appropriate handling to backend_webagg_core.

blink1073 · 2015-01-05T01:54:51Z

Wow, that felt like a battle with Travis with all the guess-and-checking.

tacaswell · 2015-01-05T02:08:43Z

lib/matplotlib/backends/web_backend/mpl.js

@@ -402,7 +419,8 @@ mpl.figure.prototype.mouse_event = function(event, name) {
    var x = canvas_pos.x;
    var y = canvas_pos.y;

-    this.send_message(name, {x: x, y: y, button: event.button});
+    this.send_message(name, {x: x, y: y, button: event.button,
+                             step: event.step});


what done js do if you have not set a value for event.step? I assume magically pass a null-like value...

JS assigns it to undefined which is translated to None AFAIK.

tacaswell · 2015-01-05T02:17:12Z

lib/matplotlib/backends/web_backend/mpl.js

+        mouse_event_fn(event);
+    }
+
+    $(canvas_div)[0].addEventListener('DOMMouseScroll', scroll_fn, false);


Can you just do canvas_div.addEventListener(...) here? We have (what I think) is a reference to the js version of the div so there is no need to look it up.

Simplified now, does not work without the [0] access though.

Then why do the next two lines work?

That wasn't meant to be hostile, I am in fact quite confused.

I'm as confused as you are.

All I know is that canvas_div has no attribute addEventListener, but canvas_div[0] does.

pelson · 2015-01-05T08:51:39Z

Nice. 👍

tacaswell · 2015-01-06T02:32:57Z

This now has conflicts with the enter/leave event PR.

blink1073 · 2015-01-06T02:40:25Z

Fixed (I hope).

blink1073 · 2015-01-07T02:11:18Z

The current code works in Firefox, Chrome, and IE. Turns out we did not need "mousewheel".

tacaswell · 2015-01-07T02:53:48Z

Do we have any brave mac users who want to help out with safari?

On Tue Jan 06 2015 at 9:11:20 PM Steven Silvester notifications@github.com
wrote:

The current code works in Firefox, Chrome, and IE. Turns out we did not
need "mousewheel".

—
Reply to this email directly or view it on GitHub
#3968 (comment)
.

tonysyu · 2015-01-07T04:04:21Z

@blink1073: How are you testing this? (I'm not talking about real tests, just a manual verification that things are working)

blink1073 · 2015-01-07T04:09:44Z

@tonysyu, start ipython and %paste this:

import matplotlib
import itertools
import numpy as np
matplotlib.use('webagg')
import matplotlib.pyplot as plt
plt.close('all')
fig, ax = plt.subplots()
x = np.linspace(0,10,100)
y = np.sin(x)
ln, = ax.plot(x,y, 'o', picker=5)
evt = []
colors = iter(itertools.cycle(['r', 'g', 'b', 'k', 'c']))
def on_event(event):
    evt.append(event)
    ln.set_color(next(colors))
    fig.canvas.draw()
    fig.canvas.draw_idle()
fig.canvas.mpl_connect('scroll_event', on_event)
plt.show()

Then click on the figure and scroll and make sure it changes colors.

tonysyu · 2015-01-07T04:18:16Z

Does the suggestion to start ipython and paste actually work on your system? IPython should choose a backend at start-up so the matplotlib.use call shouldn't have an effect. At least it doesn't on my system.

In any case, when run outside of IPython, the script works for me on Safari and Chrome on OSX. 👍

It'd be nice to have an example that can be fired up from the examples directory that tests some of these events that are difficult to test properly. I'm not necessarily suggesting it for this PR, just throwing it out there.

blink1073 · 2015-01-07T04:21:09Z

@tonysyu, thanks! (I forgot to mention I had to comment out the matplotlib import in my ipython startup file). I agree about the demos.

tacaswell · 2015-01-07T06:07:49Z

@honesty I think that the nbagg_uat.nb is that demo (which does not yet
have these tests in it)

On Tue, Jan 6, 2015, 23:21 Steven Silvester notifications@github.com
wrote:

@tonysyu https://github.com/tonysyu, thanks! (I forgot to mention I had
to comment out the matplotlib import in my ipython startup file). I agree
about the demos.

—
Reply to this email directly or view it on GitHub
#3968 (comment)
.

tacaswell · 2015-01-07T06:08:15Z

@tonysyu darn you auto correct

On Wed, Jan 7, 2015, 01:07 Thomas Caswell tcaswell@gmail.com wrote:

@honesty I think that the nbagg_uat.nb is that demo (which does not yet
have these tests in it)

On Tue, Jan 6, 2015, 23:21 Steven Silvester notifications@github.com
wrote:

@tonysyu https://github.com/tonysyu, thanks! (I forgot to mention I
had to comment out the matplotlib import in my ipython startup file). I
agree about the demos.

—
Reply to this email directly or view it on GitHub
#3968 (comment)
.

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

Conflicts: lib/matplotlib/backends/backend_webagg_core.py

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

Conflicts: lib/matplotlib/backends/backend_webagg_core.py Conflicts: lib/matplotlib/backends/backend_webagg_core.py lib/matplotlib/backends/web_backend/mpl.js

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

blink1073 · 2015-01-11T22:09:10Z

I was waiting for #3965 to merge before updating the UAT, now done.

ENH : Add Support for `scroll_event` in WebAgg and NbAgg

tacaswell · 2015-01-11T22:43:27Z

back-ported as 22eb1d5

tacaswell added the status: needs review label Jan 4, 2015

blink1073 mentioned this pull request Jan 4, 2015

Js fixes for key events + ipython notebooks #3965

Merged

2 tasks

tacaswell added this to the v1.4.3 milestone Jan 5, 2015

tacaswell reviewed Jan 5, 2015
View reviewed changes

tacaswell changed the title ~~Add Support for scroll_event in WebAgg and NbAgg~~ Add Support for scroll_event in WebAgg and NbAgg [backport to 1.4.x] Jan 5, 2015

tacaswell reviewed Jan 5, 2015
View reviewed changes

blink1073 force-pushed the web-scroll-event branch from ba77d16 to dd75e27 Compare January 6, 2015 02:39

blink1073 force-pushed the web-scroll-event branch from b50586d to 1530cc6 Compare January 6, 2015 15:09

blink1073 mentioned this pull request Jan 11, 2015

Missing Events in NbAgg Backend #3963

Closed

blink1073 added 7 commits January 11, 2015 15:58

Add scroll event handling to javascript

d3468e8

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

Add scroll event handling to webagg backend

14d396e

Conflicts: lib/matplotlib/backends/backend_webagg_core.py

Remove debug print

6f39b7d

Attach scrolling handler to canvas_div

cea9844

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

Remove debug prints

0aebfeb

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

Remove unused variable and function

cf7b73c

Revert whitespace changes

98ebe28

blink1073 added 15 commits January 11, 2015 16:01

Remove another WS change

18f8b91

Simplify event listener call

da0a36d

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

Use jquery-style wheel event

9a4cc84

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

Add scroll event handling to javascript

3945579

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

Add scroll event handling to webagg backend

ac51ebc

Conflicts: lib/matplotlib/backends/backend_webagg_core.py Conflicts: lib/matplotlib/backends/backend_webagg_core.py lib/matplotlib/backends/web_backend/mpl.js

Remove debug print

e193570

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

Attach scrolling handler to canvas_div

f20d0ee

Conflicts: lib/matplotlib/backends/web_backend/mpl.js

Revert whitespace changes

aed51fb

Fix merge conflict

890cc67

Remove temporary file

836a93f

Remove merge cruft

2f22a75

Invert sign of scroll step

fc77121

Make scroll delta work on Firefox and Chrome

75c0957

Clean up wheel function

0623766

Update UAT

b41a040

blink1073 force-pushed the web-scroll-event branch from 5470074 to b41a040 Compare January 11, 2015 22:09

tacaswell added a commit that referenced this pull request Jan 11, 2015

Merge pull request #3968 from blink1073/web-scroll-event

b9eb1ff

ENH : Add Support for `scroll_event` in WebAgg and NbAgg

tacaswell merged commit b9eb1ff into matplotlib:master Jan 11, 2015

tacaswell removed the status: needs review label Jan 11, 2015

tacaswell added a commit that referenced this pull request Jan 11, 2015

Merge pull request #3968 from blink1073/web-scroll-event

22eb1d5

ENH : Add Support for `scroll_event` in WebAgg and NbAgg

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Support for `scroll_event` in WebAgg and NbAgg [backport to 1.4.x] #3968

Add Support for `scroll_event` in WebAgg and NbAgg [backport to 1.4.x] #3968

blink1073 commented Jan 4, 2015

blink1073 commented Jan 5, 2015

tacaswell Jan 5, 2015

blink1073 Jan 5, 2015

tacaswell Jan 5, 2015

blink1073 Jan 5, 2015

tacaswell Jan 5, 2015

tacaswell Jan 5, 2015

blink1073 Jan 5, 2015

blink1073 Jan 5, 2015

pelson commented Jan 5, 2015

tacaswell commented Jan 6, 2015

blink1073 commented Jan 6, 2015

blink1073 commented Jan 7, 2015

tacaswell commented Jan 7, 2015

tonysyu commented Jan 7, 2015

blink1073 commented Jan 7, 2015

tonysyu commented Jan 7, 2015

blink1073 commented Jan 7, 2015

tacaswell commented Jan 7, 2015

tacaswell commented Jan 7, 2015

blink1073 commented Jan 11, 2015

tacaswell commented Jan 11, 2015

Add Support for scroll_event in WebAgg and NbAgg [backport to 1.4.x] #3968

Add Support for scroll_event in WebAgg and NbAgg [backport to 1.4.x] #3968

Conversation

blink1073 commented Jan 4, 2015

blink1073 commented Jan 5, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pelson commented Jan 5, 2015

tacaswell commented Jan 6, 2015

blink1073 commented Jan 6, 2015

blink1073 commented Jan 7, 2015

tacaswell commented Jan 7, 2015

tonysyu commented Jan 7, 2015

blink1073 commented Jan 7, 2015

tonysyu commented Jan 7, 2015

blink1073 commented Jan 7, 2015

tacaswell commented Jan 7, 2015

tacaswell commented Jan 7, 2015

blink1073 commented Jan 11, 2015

tacaswell commented Jan 11, 2015

Add Support for `scroll_event` in WebAgg and NbAgg [backport to 1.4.x] #3968

Add Support for `scroll_event` in WebAgg and NbAgg [backport to 1.4.x] #3968