Prevent Windows from opening command prompt (#4021) [backport to 1.4.x] #4041
Conversation
This tells Windows not to create a new window when using Subprocess to save an animation.
|
This mimics a tested solution by @kjgregory in #4021 |
tacaswell
changed the title
|
I wonder if there are other subprocess calls that this might be relevant for? |
|
btw, the comments in this patch is perfect! I know I would be scratching my head 2 years from now trying to remember why we did this! |
|
@WeatherGod this isn't my first rodeo :) "Always code as if the person who ends up maintaining your code is a violent psychopath who knows where you live." |
|
Regarding other places in matplotlib's code, have we had anyone else complain about this? I proactively changed both places in animation, but based on testing, the problem only occurred on the call that actually saved the movie. It might be specific to something the program is doing at that point, since it doesn't seem like it was a problem just from running a program in subprocess. |
|
@dopplershift, fair enough. I hate bugs like this where we know how to "fix" it, but have no real clue why it happens, or exactly what the fix is doing to prevent the problem. I guess we would have noticed by now if the latex interface was borked by a similar issue. |
|
I agree, but since I haven't run matplotlib on windows in 7 years, I'm disinclined to guess what that crazy platform needs. (I have enough problems building on my mac...) |
|
....and apparently I'm an idiot and didn't install before running tests. Fix coming. |
|
👍 LGTM |
|
Did this get tested on a mac? |
|
They just did here, the smoketests passed fine. Also the moviewriter.py example worked fine. |
BUG : Prevent Windows from opening command prompt
BUG : Prevent Windows from opening command prompt
|
cherry-picked to 1.4.x as 36a7a21 |
This tells Windows not to create a new window when using Subprocess to
save an animation.