bytes2pdatenum #4153
Merged
bytes2pdatenum #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tends strpdate2num)
|
Instead of adding another converter, would it be reasonable to modify strpdate2num so that on Py3, if it gets bytes then it does the decoding? |
|
The pep8 failures are unrelated to this change and have been fixed else where. |
|
Merging this as-is. @efiring This fixes the demo and won't break anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for issue #4126. This extends the
strpdate2numconverter class to add abytespdate2numconverter which could be used in numpy's converter argument forloadtxt,genfromtxt, etc.I have my doubts on how useful this or
strpdate2numconverters really are, however. The functionality seems orthogonal to matplotlib's core and better suited for a different library but maybe there is enough usage that it warrants being there.