Labels do not becomes color anymore in figure options panel for qt toolb... #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,6 +61,8 @@ | |||
|
|
|||
| import datetime | |||
|
|
|||
| BLACKLIST = ["Title", "Label"] | |||
There was a problem hiding this comment.
I would make these all lower case
There was a problem hiding this comment.
Can you also use a set, trivial performance gain...
|
Ok, added the set improvement. Better if the blacklist increases one day ! But the label.lower() seems to cost a lot too. Maybe check against the "brute" label is better ? |
|
The performance optimizations on the In most cases, it is simpler to normalize strings before checking them for being in the set rather than including all permutations of capitalization you want to support. |
tacaswell
added a commit
that referenced
this pull request
Apr 3, 2015
BUG : never treat title or label values as colors in qt_editor fixes #4303
|
@Acanthostega Thank you! I think this is your first mpl contribution, congratulation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering by labels is sufficient, not clean, but working.
Are you interested in making a rigid but clean widget to avoid such problems in the future ? If yes, I can probably do it in two or three weeks, when I will have sufficient time.