capsize with default in matplotlibrc #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2630,7 +2633,8 @@ def errorbar(self, x, y, yerr=None, xerr=None, | |||
| The linewidth of the errorbar lines. If *None*, use the linewidth. | |||
|
|
|||
| *capsize*: scalar | |||
| The length of the error bar caps in points | |||
| The length of the error bar caps in points; if *None*, it will | |||
| take the value from ``errorbar.capsize`` :data:`rcParam<matplotlib.rcParams>`. | |||
There was a problem hiding this comment.
This line is too long and hitting the pep8 checker.
|
Left one minor and one major comment. This looks reasonable to me other wise. Can you add an entry in https://github.com/matplotlib/matplotlib/blob/master/doc/users/whats_new/rcparams.rst please? |
|
The build has failed checks. I had a look at the output, but I would need some help understanding the error, I don't see how it is related to this patch. Help is appreciated. If this is some because the cap size has to be an integer, I would gladly change that everywhere, but some advice would be appreciated. |
|
I think the test error is unrelated. I have restarted the job |
|
Thanks! :) |
tacaswell
added a commit
that referenced
this pull request
Jun 16, 2015
ENH: errorbor capsize rcparam
|
@HDembinski Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people prefer to not have ends caps on their error bars. This patch changes the default value of capsize in various function calls to "None". Inside the body of the function, "None" is then replaced by a default value taken from rcParams (the default value is still 3) under the key "errorbar.capsize". With this patch, end caps can be changed globally or turned off completely through a setting in matplotlibrc.