Avoid making nose a dependency for matplotlib.testing.compare #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
compare-nose-dep
branch
from
3da4413
to
44ee7f9
Compare
…making nose a dependency for matplotlib.testing.compare
|
@tacaswell - not sure what happened here, I think GitHub closed this because there were 0 commits for a small time. Will try re-opening. |
|
The pep8 test is unhappy, there are two missing blank lines and one too long line. I suspect that the file you moved the exceptions out of was in the black list for pep8 checking. |
astrofrog
force-pushed
the
compare-nose-dep
branch
from
13d8af8
to
66dd550
Compare
|
@tacaswell - thanks, should be fixed now (and also fixed a couple of issues in |
|
And to prove that good deed goes un-punished, the tests are now failing because a previously black listed file is passing, see https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_coding_standards.py#L176 |
|
Fixed :) (hopefully...) |
tacaswell
added a commit
that referenced
this pull request
Jun 26, 2015
ENH: No nose dependancy for matplotlib.testing.compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by moving the exceptions that are testing framework-independent into matplotlib.testing.exceptions. I want to use functions from
matplotlib.testing.comparefor pytest and it seems unecesary to have nose as a dependency too for those functions since they are more generic.(have rebased and currently pushing to fork is taking a long time due to large repo size!)