Expose interpolation short names at module level. #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because why not ? And it makes it easier to create a widget that expose the interpolation as a drop-down menu.
Carreau
force-pushed
the
global-interpolation
branch
from
5c0fc04
to
b252fe7
Compare
|
OK, test passes. I can rebase and squash if desired. |
| } | ||
|
|
||
|
|
||
| interpolations_names = list(six.iterkeys(_interpd_)) |
There was a problem hiding this comment.
should we make this a set so that it enforces the lack of order? Don't want people using py27 to think that the entries in this list will always be in the same order.
WeatherGod
added a commit
that referenced
this pull request
Jul 22, 2015
Expose interpolation short names at module level.
|
Yeah. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because why not ?
In particular it makes it easier to create a widget that expose the interpolation
as a drop-down menu.