FIX: remove equality check in line2D.set_color #4778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes problem identified in matplotlib#4771
|
Couldn't this alternatively be fixed by wrapping with np.any or similar? As I understand the error in #4771 is due to color or self._color being an array |
|
@jenshnielsen , I think it is a bit trickier than that. Technically, color can be all sorts of things, right? So you could run into a situation where the color is a numpy array of rgba values, but then someone calls set_color() with a rgb tuple. And, wouldn't the initial setting of self._color be None? This is definitely something that traits would help with by normalizing inputs. |
|
@WeatherGod Makes sense. Merging this and normalizing with traitlets later sounds like a good plan |
WeatherGod
added a commit
that referenced
this pull request
Jul 24, 2015
FIX: remove equality check in line2D.set_color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem identified in #4771
Not doing enough validation/normalization on color on the way in.