setupext.py: let the user set a different pkg-config #4807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs documentation in the install directions + a whats_new entry. |
Use the environment variable PKG_CONFIG to determine the correct pkg-config executable. Default to 'pkg-config' if the variable is not set. This allows the user to cross compile. E.g., PKG_CONFIG can be set to 'x86_64-pc-linux-gnu-pkg-config'. I did not touch any windows specific functions, which still call 'pkg-config' directly.
|
I have updated my patch. |
|
Thank you! |
tacaswell
added a commit
that referenced
this pull request
Aug 30, 2015
BLD: setupext.py: let the user set a different pkg-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the environment variable PKG_CONFIG to determine the correct
pkg-config executable. Default to 'pkg-config' if the variable is not
set.
This allows the user to cross compile. E.g., PKG_CONFIG can be set to
'x86_64-pc-linux-gnu-pkg-config'.
I did not touch any windows specific functions, which still call
'pkg-config' directly.