Calculate text size and descent correctly #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,7 @@ | |||
| #ifndef COMPILING_FOR_10_5 | |||
| static int ngc = 0; /* The number of graphics contexts in use */ | |||
|
|
|||
| #include <Carbon/Carbon.h> | |||
There was a problem hiding this comment.
Does this put a min OSX version constraint in? I don't follow mac at all, but have a vague notion that carbon is 'new'.
There was a problem hiding this comment.
Carbon is the old api. Cocoa is the new one https://en.wikipedia.org/wiki/Carbon_(API) so I don't think so
tacaswell
added a commit
that referenced
this pull request
Jul 31, 2015
FIX: Calculate text size and descent correctly in osx backend
No that is a separate bug; see pull request #4838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of text sizes and descent were always a bit off in the MacOSX backend. For example,
will draw the xxx below the dashed line, instead of centered on it. It's hardly noticeable for common text sizes, but still it should be fixed.
This pull request fixes the text size & descent calculation, and makes sure that text appears in the correct location.