Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mep12 on print_stdout.py #4845

Merged
merged 3 commits into from Aug 4, 2015
Merged

mep12 on print_stdout.py #4845

merged 3 commits into from Aug 4, 2015

Conversation

ericmjl
Copy link
Contributor

@ericmjl ericmjl commented Aug 1, 2015

No description provided.

@@ -1,13 +1,9 @@
#!/usr/bin/env python
# -*- noplot -*-
# print png to standard out
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave in the last to lines. They explain what the example is supposed to do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the 2nd line tell us? Btw, I'm adding them back anyways, but just curious.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second line there is a Sphinx directive (Note: I might have my
terminology wrong) that tells the documentation builder to not bother
running this script to generate an output image, because it won't work. We
also use this directive for the interactive examples like the pong clone.

On Sat, Aug 1, 2015 at 11:08 PM, Eric Ma notifications@github.com wrote:

In examples/pylab_examples/print_stdout.py
#4845 (comment):

@@ -1,13 +1,9 @@
-#!/usr/bin/env python
-# -- noplot --
-# print png to standard out

What does the 2nd line tell us? Btw, I'm adding them back anyways, but
just curious.


Reply to this email directly or view it on GitHub
https://github.com/matplotlib/matplotlib/pull/4845/files#r36039118.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I actually meant the last two lines but the plot directive should stay too

@jenshnielsen jenshnielsen added the MEP: MEP12 gallery and examples improvements label Aug 1, 2015
@ericmjl
Copy link
Contributor Author

ericmjl commented Aug 3, 2015

Is the failure a usual "travis random failure"? It looks like so, but I'd like to double-check to be sure.

@jenshnielsen
Copy link
Member

Yes that is just a random failure. Thou not one of the usual ones. It failed because the network connection between the box and PyPi failed when pip installing dependencies

@ericmjl
Copy link
Contributor Author

ericmjl commented Aug 3, 2015

Got it, thank @jenshnielsen!

@ericmjl
Copy link
Contributor Author

ericmjl commented Aug 4, 2015

Anything else needed here too?

@jenshnielsen
Copy link
Member

Could you add back the line # usage: python print_stdout.py > somefile.png
Sorry that my original comment was confusing

@ericmjl
Copy link
Contributor Author

ericmjl commented Aug 4, 2015

Ok, all done :)

jenshnielsen added a commit that referenced this pull request Aug 4, 2015
@jenshnielsen jenshnielsen merged commit d37df04 into matplotlib:master Aug 4, 2015
@ericmjl ericmjl deleted the mep12_print_stdout.py branch August 4, 2015 16:52
@QuLogic QuLogic added this to the v1.5.0 milestone Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEP: MEP12 gallery and examples improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants