Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mep12 on multiple_figs_demo.py #4861

Merged
merged 2 commits into from Aug 4, 2015
Merged

mep12 on multiple_figs_demo.py #4861

merged 2 commits into from Aug 4, 2015

Conversation

ericmjl
Copy link
Contributor

@ericmjl ericmjl commented Aug 4, 2015

No description provided.

plt.figure(1)
plt.savefig('fig1')
plt.figure(2)
plt.savefig('fig2')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these savefigs are worth keeping around. I think the lesson of the example is clear enough without them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will take them out then.

@ericmjl
Copy link
Contributor Author

ericmjl commented Aug 4, 2015

What's the error here? I don't see pep8 issues, and local test shows the code works just fine.

@dopplershift
Copy link
Contributor

It looks to me like a transient failure. I restarted that particular test, so we can see if that passes now.

@dopplershift
Copy link
Contributor

Looks like that fixed it.

@dopplershift dopplershift added the MEP: MEP12 gallery and examples improvements label Aug 4, 2015
@dopplershift dopplershift added this to the next point release milestone Aug 4, 2015
dopplershift added a commit that referenced this pull request Aug 4, 2015
@dopplershift dopplershift merged commit 76655e2 into matplotlib:master Aug 4, 2015
@ericmjl ericmjl deleted the multiple_figs_demo.py_mep12 branch August 4, 2015 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEP: MEP12 gallery and examples improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants