broken_barh does not properly support units #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2275,6 +2275,11 @@ def broken_barh(self, xranges, yrange, **kwargs): | |||
|
|
|||
| .. plot:: mpl_examples/pylab_examples/broken_barh.py | |||
| """ | |||
| # process the unit information | |||
| self._process_unit_info(xdata=xranges[0], ydata=yrange[0], kwargs=kwargs) | |||
There was a problem hiding this comment.
This line is too long, could you please wrap it?
|
Just restarted one of the Travis jobs (it is a known intermittent error due to Travis). Things look good here. It just would be nice to have a test to catch these things in the future. Not sure how to do that without adding dependencies, though. @dopplershift , do you have any suggestions on that? |
|
Well, there's a "mini" unit library in the unit examples. All of my own testing to date relies upon |
tacaswell
added a commit
that referenced
this pull request
Aug 14, 2015
FIX: broken_barh does not properly support units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broken_barh and hist were not handling unitized data.
This addresses an issue in #4897.