Make sure _edgecolors is a string before comparison to string. #4925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes numpy deprecation warning. Comparing a numpy array to a string will return an array in future numpy versions
tacaswell
added a commit
that referenced
this pull request
Aug 15, 2015
MNT: Make sure _edgecolors is a string before comparison to string.
|
This is not in 1.5, is it? It would be awesome to have ;) |
|
It should be 1.5 was branched from master after this was merged and it is on the 1.5.x branch https://github.com/matplotlib/matplotlib/blob/v1.5.x/lib/matplotlib/collections.py#L624 |
|
Ah, never mind. I messed up my environment by trying to pip install into a conda env. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes numpy deprecation warning raised in numpy 1.10 beta
Comparing a numpy array to a string will return an array in future numpy versions breaking these if statements.