Mep12 image origin.py #4950
Mep12 image origin.py #4950
Conversation
| x.shape = (10, 10) | ||
|
|
||
| interp = 'bilinear' | ||
| #interp = 'nearest' | ||
| # interp = 'nearest' |
There was a problem hiding this comment.
your autopep8 is showing again... it is not supposed to be putting a space in here for commented out code. This is true in a few places.
There was a problem hiding this comment.
my editor complain to be about that too, I tend to fix those when I go on pep8 binges.
There was a problem hiding this comment.
interesting, I didn't do autopep8. Maybe my mind is autopep8-ing the code........ Let me fix that.
There was a problem hiding this comment.
Thing is, the pep8 check will fail if I don't insert the space. That will affect the pep8-checking build on Travis, causing it to fail.
There was a problem hiding this comment.
We have a pretty extensive black list of ignored pep8 rules (such as the pair that as near as I can tell are conflicting).
There was a problem hiding this comment.
Ok, got it. Removing...
There was a problem hiding this comment.
Besides, if your linter is saying that that removing that space is a
violation of PEP8, then it is broken. Any linter that can not recognize
commented-out code is not worth using (in any language).
On Tue, Aug 18, 2015 at 8:14 PM, Eric Ma notifications@github.com wrote:
In examples/pylab_examples/image_origin.py
#4950 (comment):x.shape = (10, 10)
interp = 'bilinear'
-#interp = 'nearest'
+# interp = 'nearest'Ok, got it. Removing...
—
Reply to this email directly or view it on GitHub
https://github.com/matplotlib/matplotlib/pull/4950/files#r37368671.
There was a problem hiding this comment.
Right now I'm doing checking without a linter. Basically running vanilla pep8 [filename].py.
No description provided.