FIX: double z-axis draw in mplot3D #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we moved `Axes.draw` to use `Axes.get_children` to get the initial list of artists to draw the zaxis was now in this list (where as it was not previously). The 3D axes use `_axison = False` as `Axes3D` manages the drawing of the axis objects (which must happen before any of the artists). In `Axes.draw` there is a special case to remove the x and y axis from the draw list if `not _axison`. This change is to add a `_get_axis_list` method to the `Axes` base class and override this in the `Axes3D`. This list is looped over to remove all of the `axis` objects that when the axises should not be shown. Closes matplotlib#4971
The first time the Axes3D is drawn the x,y,z axis are drawn before the aspect has been adjusted so they are wrong (the double zaxis the previous commit removed was actually the correct one). This copies the relevant code up to the Axes3D level. This is not great as there is code-duplication, but the 'correct' solution is to make the Axes.draw method much more pluggable which is a very large job.
|
Wow, I hadn't fully appreciated the implications of |
WeatherGod
added a commit
that referenced
this pull request
Aug 26, 2015
FIX: double z-axis draw in mplot3D
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we moved
Axes.drawto useAxes.get_childrento get the initiallist of artists to draw the zaxis was now in this list (where as it was
not previously). The 3D axes use
_axison = FalseasAxes3Dmanagesthe drawing of the axis objects (which must happen before any of the
artists). In
Axes.drawthere is a special case to remove the x and yaxis from the draw list if
not _axison.This change is to add a
_get_axis_listmethod to theAxesbase classand override this in the
Axes3D. This list is looped over to removeall of the
axisobjects that when the axises should not be shown.Closes #4971
attn @WeatherGod @jenshnielsen