New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Travis job with 3.6 nightly #5014
Conversation
I think we need the pre flag to get numpy to install? |
@tacaswell You are right. I am a bit unhappy that the |
cf90a84
to
a6efc33
Compare
I fixed the majority of the 3.6 test failures by replacing The remaining failures are due to Edit: Clarified that the issue with signature is purely timing with respect to 1.5 |
My only concern is that this is going to conflict with the changes to boilerplate in #4829 |
Makes sense. I suggest waiting with this one until #4829 is merged. Rebasing from this side should be much easier. |
This job is allowed to fail. Also move the --pre flag to this job
Needed because the wheelhouse does not correctly handle missing versions
Prefere this over getargspec which will be removed in 3.6. This is the least intrusive change however getfullargspec has been deprecated too. Post 2.0 we should rewrite the code to use signature instead
a6efc33
to
22f532e
Compare
Rebased after #4829 was merged, It's probably to late now but it would be nice to get in before 1.5 since matplotlib basically don't work without in Python 3.6. Most of the tests pass now but nose still uses getargspec so a few of the tests fail |
This is a bugfix. |
FIX/TST: Add 3.6 compatibility testing
Drat, I was fooled by the green-check on this page, there are still a few instances of |
And I read the failure too fast and now see that these are the failures due to nose that @jenshnielsen mentioned above, sorry for the noise. |
As suggested in #5009
This job is allowed to fail and I expect it to fail due to the removal of the deprecated
inspect.getargspec
I have also moved the --pre flag to this job from the 3.5rc2 one