mathtext: Add - to spaced symbols, and do not space symbols at start of string
#5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| prev_char = s[loc-i] | ||
| while prev_char == ' ' and i <= loc: | ||
| i += 1 | ||
| prev_char = s[loc-i] |
There was a problem hiding this comment.
I think it would be more pythonic to use six.xrange for this loop: i.e.:
for i in six.xrange(1, loc + 1):
There was a problem hiding this comment.
Definitely, I wasn't very happy with that loop
There was a problem hiding this comment.
It will need a break then:
for i in six.moves.xrange(1, loc + 1):
prev_char = s[loc-i]
if prev_char != ' ':
break
|
@mdboom: Anything else that should be changed in this PR? |
|
No, this looks fine to me. |
mdboom
added a commit
that referenced
this pull request
Sep 8, 2015
mathtext: Add `-` to spaced symbols, and do not space symbols at start of string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to changes in symbol spacing made in #4872. This PR does two things:
-to set of_binary_operatorsthat are then considered in_spaced_symbols, so that-is spaced equivalently to+:$1-2$should be spaced exactly as$1+2$.-and+) is at the start of the string or of a unit delimited by{ }. This makes things like$+2$or$21^{+2}_{-3}$more natural, as the+or-are not really a binary operator anymore but part of the number.A test has been added to check for spacing in the second item, so that
$-2$; $ -2$; ${-2}$; ${ -2}$all render equally, but with different spacing than$6-2$.attn @mdboom, @tacaswell (also sorry for not catching this in #4872!)