ENH Better error message when providing wrong fontsizes #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| raise ValueError("%s is not a valid font size. Valid font sizes " | ||
| "are %s." % (s, ", ".join(fontsizes))) | ||
|
|
||
|
|
||
| validate_fontsizelist = _listify_validator(validate_fontsize) |
There was a problem hiding this comment.
PEP8 question... does the 2 blank line rule have to be right after the function, or can it wait until after ancillary actions like munging of docstrings and such?
There was a problem hiding this comment.
I don't fix so, but I'm not sure.
NelleV
changed the title
tacaswell
added a commit
that referenced
this pull request
Sep 5, 2015
ENH: Better error message when providing wrong fontsizes
QuLogic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small PR, to print a better error message when we provide a wrong fontsize.
It now prints
normal is not a valid font size. Valid font sizes are xx-small, x-small, small, medium, large, x-large, xx-large, smaller, larger.