New Colormaps to docs #5284
Merged
New Colormaps to docs #5284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also partly pep8 and make the figure a bit smaller
Pep8 and tweak size
Re: @stefanv's comment
Refactor to reduce duplication
|
Looks like the docs build doesn't work correctly
|
|
Otherwise Looks good to me. Thanks for finishing this @mdboom |
|
|
||
| Miscellaneous | ||
| ------------- | ||
|
|
||
| Some of the miscellaneous colormaps have particular uses they have been created for. For example, gist_earth, ocean, and terrain all seem to be created for plotting topography (green/brown) and water depths (blue) together. We would expect to see a divergence in these colormaps, then, but multiple kinks may not be ideal, such as in gist_earth and terrain. CMRmap was created to convert well to grayscale, though it does appear to have some small kinks in :math:`L^*`. cubehelix was created to vary smoothly in both lightness and hue, but appears to have a small hump in the green hue area. | ||
| Some of the miscellaneous colormaps have particular uses they have been created | ||
| for. For example, gist_earth, ocean, and terrain all seem to be created for |
There was a problem hiding this comment.
"for which they have been created."
|
Everything else looks good to me once Travis passes. |
jenshnielsen
added a commit
to jenshnielsen/matplotlib
that referenced
this pull request
Oct 21, 2015
New Colormaps to docs
jenshnielsen
added a commit
that referenced
this pull request
Oct 21, 2015
Backport Merge pull request #5284 from mdboom/colormap-docs
|
Backported as 7b4bb9e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes and includes #4965, since I'd like to get this in for 1.5.0 and @jenshnielsen noted he may be busy this week.
It addresses the remaining comments in #4965, namely to create a new category for the new perceptually uniform colormaps, and some prose improvements in the text.