Fix some compiler warnings #5285
Conversation
| @@ -1843,7 +1843,6 @@ void qh_initqhull_start2(FILE *infile, FILE *outfile, FILE *errfile) { | |||
| time_t timedata; | |||
| int seed; | |||
|
|
|||
| qh_CPUclock; /* start the clock(for qh_clock). One-shot. */ | |||
There was a problem hiding this comment.
We shouldn't modify anything in extern/qhull as it is a verbatim copy of the qhull source code. I'd prefer to leave it as it is and accept compiler warnings rather than change it.
There was a problem hiding this comment.
Looks like this was only partly reverted the comment is missing
|
I am happy with the changes to the two wrapper files, making them consistent with other wrappers. |
|
Of course, you're right about extern. Missed that. I'll revert that change. |
mdboom
force-pushed
the
compiler-warnings
branch
from
a1e00fe
to
f1c9c07
Compare
|
I've added some more warning fixes from gcc (the others were from clang) |
|
👍 I have been intending to silence some warnings for some time but have not gotten around to doing it |
| @@ -480,10 +480,7 @@ extern "C" { | |||
|
|
|||
| struct module_state | |||
| { | |||
| /* The Sun compiler can't handle empty structs */ | |||
There was a problem hiding this comment.
Is this comment referring to the module_state struct itself or the allocation that occurs at some other point? Because I don't see why this can't be remove entirely and just a straightforward 0 passed for the size.
|
Backported to 1.5.x as b7c76c5 |
No description provided.