Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove various Python 2.6 related workarounds #5373

Merged
merged 8 commits into from Nov 5, 2015

Conversation

jenshnielsen
Copy link
Member

Now that we don't support 2.6 any more we might as well get rid of this. This is what I found from grepping the code so there might as well be more that we can delete.

I also fixed the version check in __init__ we might want to backport that to 2.0.x

@jkseppan
Copy link
Member

The changes look good to me, and the tests are passing. I guess one question may be whether we want to error out immediately when running in 2.6, or just give a warning and try to run in any case, since at least the way I understood the announcement as merely withdrawing "official support".

@jenshnielsen
Copy link
Member Author

With #5299 merged (which depends on functool32 which is python 2.7 and later only) I think we have broken 2.6 support fully. This should not go into 1.5.x which should still work with 2.6

@jkseppan
Copy link
Member

jkseppan commented Nov 1, 2015

You're right, Python 2.6 won't run current master. 👍

@mdboom
Copy link
Member

mdboom commented Nov 2, 2015

~~We may also want to consider a friendly error message on Python 2.6 from setup.py similar to the one in __init__.py. No point in installing it only to find out it won't work later. As it stands, the user gets:

Running functools32-3.2.3-2/setup.py -q bdist_egg --dist-dir /tmp/easy_install-rNTUH7/functools32-3.2.3-2/egg-dist-tmp-ot6OvI
This backport is for Python 2.7 only.

which refers to functools32, which might lead to a bug report to us. Better to just say "matplotlib requires 2.7, 3.3, 3.4 or 3.5" and be done with it.~~

EDIT: Sorry, I missed the check in setupext.py. That's great.

@tacaswell tacaswell added this to the next bug fix release (2.0.1) milestone Nov 2, 2015
tacaswell added a commit that referenced this pull request Nov 5, 2015
CLN: Remove various Python 2.6 related workarounds
@tacaswell tacaswell merged commit 18beeb9 into matplotlib:master Nov 5, 2015
tacaswell added a commit that referenced this pull request Nov 5, 2015
CLN: Remove various Python 2.6 related workarounds
@tacaswell
Copy link
Member

back-ported to v2.0.x as 1866a8c

@jenshnielsen jenshnielsen deleted the python26removal branch November 9, 2015 09:23
@QuLogic QuLogic modified the milestones: 2.0 (style change major release), 2.0.1 (next bug fix release) Jul 18, 2016
@QuLogic QuLogic mentioned this pull request Oct 21, 2016
@joranbeasley
Copy link

can you at least tell me which version i should install if i do want py2.6?

@WeatherGod
Copy link
Member

WeatherGod commented Feb 14, 2017 via email

@tacaswell
Copy link
Member

The 1.4 series is the last versions to officially support python 2.6.

There was a loing discusion about this in 2015 http://matplotlib.1069221.n5.nabble.com/Matplotlib-devel-supported-python-versions-tt46154.html and no one volunteered to take care of 2.6 compatible branch so it got dropped.

@joranbeasley I have deleted your comment. Insulting core maintainers (who are volunteers) is not condusive to us taking your concerns seriously. Please be civil in our channels.

@WeatherGod
Copy link
Member

WeatherGod commented Feb 14, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants