Remove setup.py tests and adapt docs to use tests.py #5434
Conversation
|
👍 in principle but want to be careful to not conflict with #5405 too badly. @pizzathief Your branch needs a resbase anyway. How much of a hassle would it be for us to merge this as-is and than have you re-base on top of the new master? |
|
Im ok with rebasing this if need be. I think we should change the docs as soon as possible for the next release. Actually removing the method can better wait |
|
Actually, could you split this up in to a documentation only commit? That I am +1 on merging the docs and rebuilding what we have deployed for 1.5 On Wed, Nov 11, 2015, 08:25 Jens Hedegaard Nielsen notifications@github.com
|
|
I will cherry-pick to a new branch with the docs changes only and target the 1.5 docs branch |
|
reasonably hassle free, I think. |
|
@jenshnielsen What is the state of this PR? I think this needs to be re-bassed because the docs only PR was merged. |
jenshnielsen
force-pushed
the
nosetuptest
branch
from
cddae28
to
d9caef3
Compare
|
@tacaswell Yes you are right. Rebase done |
Remove setup.py tests and adapt docs to use tests.py
|
@mdboom any problem porting this all they way back to v1.5.0-doc? |
|
The docs part was merged in #5462 so I guess that this can just be backported to 1.5.x ? |
|
Great, thanks for remembering that. |
Remove setup.py tests and adapt docs to use tests.py conflicts in setup.py due to parts of #5604 being back-ported as well. Removed the windows bdist patch code to resolve.
|
backported to v1.5.x as 4a705d1 |
Given the number of issues that we have been seeing with
setup.py test#4720 and #5315 among others I suggest removing it and recommending
python tests.pyWe already have 2/3 other ways of running the tests and the only thing that
setup.py testbrings is the ability to install the test dependencies which is done inside the build enviroment with setuptools only available to the test process. I think it is better just to recommend manually installing the test dependencies.