Fix #5444: do not access subsuper nucleus _metrics if not available #5448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
added a commit
that referenced
this pull request
Nov 9, 2015
Fix #5444: do not access subsuper nucleus _metrics if not available
mdboom
added a commit
that referenced
this pull request
Nov 9, 2015
Fix #5444: do not access subsuper nucleus _metrics if not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #5444: we were previously using the last characters'
_metricsto define the advance, but when the last character is aVlistorHlistthey don't have a_metricsattribute. Now we check for it before accessing it. I also added a test for it that was previously missing.@mdboom - I did this PR against master, but should likely be backported to 1.5.x and 2.0.x. I split the baseline images commits, with cm and stix in one and dejavu in another, so that only the first should go into 1.5.x but both of them into 2.0.x.