Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boxplot params to rctemplate #5526

Merged
merged 2 commits into from Nov 20, 2015

Conversation

phobson
Copy link
Member

@phobson phobson commented Nov 19, 2015

Also flailing here.

Part of the work that goes with #5523.

Aims to close #5441

@WeatherGod
Copy link
Member

Don't forget to add them to the classic style, if they aren't there already.

On Thu, Nov 19, 2015 at 6:24 PM, Paul Hobson notifications@github.com
wrote:

Also flailing here.

Part of the work that goes with #5523
#5523.

Aims to close #5441 #5441

You can view, comment on, or merge this pull request online at:

#5526
Commit Summary

  • added boxplot params (w/ current default) to mplrc

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#5526.

@mdboom
Copy link
Member

mdboom commented Nov 20, 2015

They are already in the classic style, though I discovered a bug in them yesterday. boxplot.flierprops.linestyle was copied incorrectly from the old default in rcsetup.py. This causes tests to fail when you decrease the tolerance down to 0.

@phobson: Maybe you could make this change here as well?

diff --git a/lib/matplotlib/mpl-data/stylelib/classic.mplstyle b/lib/matplotlib/mpl-data/stylelib/classic.mplstyle
index 0f61a53..86b4c22 100644
--- a/lib/matplotlib/mpl-data/stylelib/classic.mplstyle
+++ b/lib/matplotlib/mpl-data/stylelib/classic.mplstyle
@@ -322,11 +322,11 @@ boxplot.capprops.color: k
 boxplot.capprops.linestyle: -
 boxplot.capprops.linewidth: 1.0
 boxplot.flierprops.color: b
-boxplot.flierprops.linestyle: -
+boxplot.flierprops.linestyle: none
 boxplot.flierprops.linewidth: 1.0
 boxplot.flierprops.marker: +
 boxplot.flierprops.markeredgecolor: k

@tacaswell tacaswell added this to the next major release (2.0) milestone Nov 20, 2015
@phobson
Copy link
Member Author

phobson commented Nov 20, 2015

@mdboom done! that explains why my result images in default boxplot style PR were so o_0

@phobson
Copy link
Member Author

phobson commented Nov 20, 2015

Ok, I've confirmed that #5523 depends on this to produce meaningful test images

tacaswell added a commit that referenced this pull request Nov 20, 2015
@tacaswell tacaswell merged commit 0834f7e into matplotlib:master Nov 20, 2015
@phobson phobson deleted the add-bxpparams-to-rctemplate branch November 20, 2015 22:19
@phobson phobson changed the title WIP: Add boxplot params to rctemplate Add boxplot params to rctemplate Nov 20, 2015
tacaswell added a commit that referenced this pull request Nov 20, 2015
@tacaswell
Copy link
Member

back-ported to v2.0.x as 071fc5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boxplot rcParams are not in matplotlibrc.template
4 participants