New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend tuple handler improve #5617
Legend tuple handler improve #5617
Conversation
0828170
to
f480028
Compare
Eh, sry, I screwed up with the initial push. Hopefully it's okay now. |
👍 awesome attn @mdboom re question about freetype. |
To create consistent text output, you need to set |
@QuLogic is exactly right about freetype here. This is new since 1.5.x, so is documented in the "devdocs", not the default doc version, here: http://matplotlib.org/devdocs/devel/testing.html#building-matplotlib-for-image-comparison-tests |
f480028
to
ca68182
Compare
Okay, I've recreated the test with the built-in FreeType version. |
'power cycling' this PR to make it rebuild against current master. |
- Add what's new entry - Update legend guide - Document HandlerTuple's default values
ca68182
to
d255e50
Compare
Rebased. Last time a Python 2.7 test failed that seemed unrelated to me (matplotlib.tests.test_mathtext.test_mathfont_stix_07.test). Let's see if that is still the case. |
---------- | ||
|
||
ndivide : int, optional | ||
The number of sections to divide the legend area into. If 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use None
as the sentinel value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
I think this needs a whats_new entry? |
I put a description in Edit: sry, I was in a hurry. What I meant to say: @WeatherGod did you notice the description in If not, is that what you had in mind? |
@Three-Comrades Yes, that looks sufficient to me. |
👍 from me, but I will refrain from pushing the green button because I have commits in this PR. |
…rove Legend tuple handler improve
Continuation of #2904 and #2034.
Rebased, added some more documentation and adapted the example a bit.
I'm not sure how to ceate the test image. I created it on Ubuntu 14.04. which uses version 2.5.2 of the Freetype library - do I need to compile+install 2.5.3, or even the exact, possibly patched Fedora version that was used to create the rest of the images?