Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend tuple handler improve #5617

Merged
merged 9 commits into from Mar 19, 2016

Conversation

jmehne
Copy link
Contributor

@jmehne jmehne commented Dec 4, 2015

Continuation of #2904 and #2034.

Rebased, added some more documentation and adapted the example a bit.

I'm not sure how to ceate the test image. I created it on Ubuntu 14.04. which uses version 2.5.2 of the Freetype library - do I need to compile+install 2.5.3, or even the exact, possibly patched Fedora version that was used to create the rest of the images?

@jmehne
Copy link
Contributor Author

jmehne commented Dec 4, 2015

Eh, sry, I screwed up with the initial push. Hopefully it's okay now.

@tacaswell tacaswell added this to the proposed next point release (2.1) milestone Dec 4, 2015
@tacaswell
Copy link
Member

👍 awesome

attn @mdboom re question about freetype.

@QuLogic
Copy link
Member

QuLogic commented Dec 4, 2015

To create consistent text output, you need to set local_freetype = True in setup.cfg before building to use a specific version of FreeType instead of the system one.

@mdboom
Copy link
Member

mdboom commented Dec 5, 2015

@QuLogic is exactly right about freetype here. This is new since 1.5.x, so is documented in the "devdocs", not the default doc version, here:

http://matplotlib.org/devdocs/devel/testing.html#building-matplotlib-for-image-comparison-tests

@jmehne jmehne force-pushed the legend-tuple-handler-improve branch from f480028 to ca68182 Compare December 5, 2015 21:52
@jmehne
Copy link
Contributor Author

jmehne commented Dec 5, 2015

Okay, I've recreated the test with the built-in FreeType version.

@tacaswell
Copy link
Member

'power cycling' this PR to make it rebuild against current master.

@jmehne jmehne force-pushed the legend-tuple-handler-improve branch from ca68182 to d255e50 Compare March 19, 2016 11:41
@jmehne
Copy link
Contributor Author

jmehne commented Mar 19, 2016

Rebased. Last time a Python 2.7 test failed that seemed unrelated to me (matplotlib.tests.test_mathtext.test_mathfont_stix_07.test). Let's see if that is still the case.

----------

ndivide : int, optional
The number of sections to divide the legend area into. If 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use None as the sentinel value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@WeatherGod
Copy link
Member

I think this needs a whats_new entry?

@jmehne
Copy link
Contributor Author

jmehne commented Mar 19, 2016

I put a description in doc/users/whats_new/multiple_legend_keys.rst. Is that enough?

Edit: sry, I was in a hurry. What I meant to say: @WeatherGod did you notice the description in doc/users/whats_new/multiple_legend_keys.rst?

If not, is that what you had in mind?
If so, what exactly are you missing compared to that description? :)

@tacaswell
Copy link
Member

@Three-Comrades Yes, that looks sufficient to me.

@tacaswell
Copy link
Member

👍 from me, but I will refrain from pushing the green button because I have commits in this PR.

WeatherGod added a commit that referenced this pull request Mar 19, 2016
@WeatherGod WeatherGod merged commit 4230879 into matplotlib:master Mar 19, 2016
@jmehne jmehne deleted the legend-tuple-handler-improve branch March 19, 2016 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants