Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in pyplot_scales.py #5644

Merged
merged 1 commit into from Dec 9, 2015
Merged

Fix typo in pyplot_scales.py #5644

merged 1 commit into from Dec 9, 2015

Conversation

WeatherGod
Copy link
Member

Closes #5642

@WeatherGod
Copy link
Member Author

Huh, the web-based editor doesn't seem to make the branch on your own repo, but in the same repo as the project. Oops! We should make sure that we delete this branch once done.

@tacaswell tacaswell added this to the Critical bugfix release (1.5.1) milestone Dec 9, 2015
@mdboom
Copy link
Member

mdboom commented Dec 9, 2015

That's weird about the web-based editor making a branch in the main repo. I feel like it didn't used to do that, but I don't use that feature very often. I hope that only happens for those of us with commit rights to matplotlib (and I suspect it does) otherwise it's a definite authorization violation.

@jenshnielsen
Copy link
Member

It's a new feature that it allows you to create a branch and make a PR. It just used to directly edit files in the current branch.

@WeatherGod
Copy link
Member Author

I am pretty sure I remember some people contributing tiny patches to us
from the editor before that didn't have commit rights. I suspect my issue
is that I have commit rights, so it picked this repo instead of my fork. I
probably should have done the edit in my fork instead, but I am not sure it
would have made a PR against matplotlib's repo. Weird.

On Wed, Dec 9, 2015 at 10:34 AM, Jens Hedegaard Nielsen <
notifications@github.com> wrote:

It's a new feature that it allows you to create a branch and make a PR. It
just used to directly edit files in the current branch.


Reply to this email directly or view it on GitHub
#5644 (comment)
.

@jenshnielsen
Copy link
Member

@WeatherGod If you do it agains a repo where you don't have rights it does indeed fork however if you had rights it used to only allow you to edit the files in place on the branch.

@WeatherGod
Copy link
Member Author

This looks good to go.

tacaswell added a commit that referenced this pull request Dec 9, 2015
@tacaswell tacaswell merged commit fb4d7b7 into master Dec 9, 2015
@tacaswell tacaswell deleted the WeatherGod-docfix branch December 9, 2015 19:36
tacaswell added a commit that referenced this pull request Dec 9, 2015
@tacaswell
Copy link
Member

backported to v1.5.0-doc as 37f08ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants