Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer axes names in selector for figure options. #5667

Merged
merged 1 commit into from Dec 15, 2015

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 13, 2015

Replace the old label, which included the legthy repr of the axes
object, to a nicer label which emphasizes the title or axes labels
(depending on what is present). Also drops the use of the label of the
Axes object itself, for which I haven't found any other reference or use
in general. (Another option would be to use solely Axes.get_label()
when defined, as this doesn't seem to have any other use.)

See #5468.

elif label:
fmt = "%(axes_repr)s (%(label)s)"
name = title
elif xlabel and ylabel:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe be a bit more forgiving on this and allow only one of them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Replace the old label, which included the legthy repr of the axes
object, to a nicer label which emphasizes the title or axes labels
(depending on what is present).  Also drops the use of the label of the
Axes object itself, for which I haven't found any other reference or use
in general.  (Another option would be to use solely `Axes.get_label()`
when defined, as this doesn't seem to have any other use.)

See matplotlib#5468.
tacaswell added a commit that referenced this pull request Dec 15, 2015
Nicer axes names in selector for figure options.
@tacaswell tacaswell merged commit ef9bbe2 into matplotlib:master Dec 15, 2015
@tacaswell
Copy link
Member

👍 keep up the good work!

@anntzer anntzer deleted the friendlier-axes-selector branch December 15, 2015 06:04
@QuLogic QuLogic added this to the proposed next point release (2.1) milestone Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants