Correct regex in filterwarnings #5735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method name has changed, also enable an assert which should have been enabled earlier
|
Actually I would probably prefer changing the error message. The message is inside subplots() not add_subplots so not sure whats going on |
|
Implemented the other solution in the second commit |
tacaswell
added a commit
that referenced
this pull request
Dec 23, 2015
FIX: Correct regex in filterwarnings
tacaswell
modified the milestones:
proposed next point release (2.1),
Critical bugfix release (1.5.1)
|
This does not cherry-pick cleanly back to 1.5.x because where The assert should be uncommented on 1.5.x in a it's own PR. |
|
Ok I will do a PR to fix the assert on 1.5.x |
|
thanks. |
jenshnielsen
added a commit
to jenshnielsen/matplotlib
that referenced
this pull request
Dec 23, 2015
Backport of relevant part of matplotlib#5735
|
Done as #5736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method name has changed, also enable an assert which should have been enabled earlier