Fix eb rasterize #5773
Merged
Fix eb rasterize #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2873,7 +2873,8 @@ def xywhere(xs, ys, mask): | |||
| plot_kw['markeredgewidth'] = capthick | |||
| # For backwards-compat, allow explicit setting of | |||
| # 'mew' or 'markeredgewidth' to over-ride capthick. | |||
| for key in ('markeredgewidth', 'mew', 'transform', 'alpha', 'zorder'): | |||
| for key in ('markeredgewidth', 'mew', 'transform', 'alpha', | |||
| 'zorder', 'rasterized'): | |||
There was a problem hiding this comment.
you know... I only added this one tiny bit of logic back in the day for handling "mew" in case users already figured out how to adjust the cap thickness (it was never documented). I intended to deprecate that at some point, but forgot to do that. I didn't think it would ever be used for other things like this. Perhaps there are other keyword arguments that should be checked?
|
heh, no worries. We will figure it out eventually! |
|
backported to v1.5.x as 016ef98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #5466
If travis passes I plan to self merge this