Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build children to run #5881

Merged
merged 1 commit into from Jan 20, 2016

Conversation

jenshnielsen
Copy link
Member

This was a regression from the moving of the file which resulted in the launching of the OSX builds to fail. This only applies on the master branch since the 2.x and 1.5.x branch don't have this issue

This was a regression from the moving of the file
@QuLogic
Copy link
Member

QuLogic commented Jan 19, 2016

Where do OSX builds run? Not on Travis?

@jenshnielsen
Copy link
Member Author

You can only build one type of travis jobs in one script. This triggers another travis job that does the osx build

@QuLogic
Copy link
Member

QuLogic commented Jan 19, 2016

That's not true; you can specify the os key in the build matrix. For example, libsass does so and their builds run on Linux and OSX in one go.

@jenshnielsen
Copy link
Member Author

Ok, I didn't know that it's probably worth investigating to port our jobs to run OSX in the same job. Never the less this was originally setup to trigger a child job (not by me) to run on OSX and as as far as I know that was because there was no support for running mixed OS jobs at that time.

@QuLogic
Copy link
Member

QuLogic commented Jan 20, 2016

In any case, I don't think anything could go wrong here.

QuLogic added a commit that referenced this pull request Jan 20, 2016
@QuLogic QuLogic merged commit 02f4cdb into matplotlib:master Jan 20, 2016
@QuLogic QuLogic added this to the proposed next point release (2.1) milestone Jan 20, 2016
@jenshnielsen jenshnielsen deleted the allowbuild_children branch January 21, 2016 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants