getter for ticks for colorbar #6170
Conversation
|
Can you add a simple test for this? Is this consistent with similar method on the x and y axis? Does this do the mapping to data space? |
|
I've checked and it does work properly with both a horizontal and vertical axis for a colorbar. In relation to testing, what would be consider a good test? is simply comparing the ticks that are set and the ticks that are return by the method enough? Also, still wondering if having ticks returned in a list is acceptable. |
| :return: an array of all ticks in the locator | ||
| """ | ||
|
|
||
| return self.locator.tick_values(0, 0) |
|
By consistent, I mean what would you use to get the ticks are for the x or y axis. A good test would be to construct an example where you know what the tick should be and then check that they are in fact what you expect. I think this is going to have to be a bit more involved and possible involve a refactor of |
|
I've created the necessary implementation of xticks and yticks in correlation to the behaviour that axis class does. I'm creating the tests right now for my implementation . Also, refactoring _ticker might not be necessary considering that the 2 methods I created are the same as axis's ticker getters behaviour. |
|
@yongzhez I don't think those two methods are useful for Colorbar. It looks like #6216 is closer to doing the right thing, but still needs work. Notice that a Colorbar has ticks only on one axis; and that the tick locations as returned by your methods are not in data coordinates, so they don't address #5792. |
|
I see, I used your suggestion to basically add a _tick_data_values field. I also added a test to correspond with this to test for the 2 returned list for a horizontal and vertical colorbar. I chose to go the path of a getter simply for consistency sake, but I can change when required. |
|
I've added the case that the user does not set their own ticks and updated the tests to correspond. |
|
I'm sorry, but I think your approach is still not correct. We don't want to recalculate the data tick values, we want to save them at the point where they are already being calculated. And it looks to me like the values you are recalculating or grabbing are not the data values at all. |
|
I apologize @efiring , I have noted that update_ticks() already calls _ticker() so I can just assign the ticks there. I also now return the data as a list of all the ticks. Is that sufficient? |
|
@yongzhez I think you missed a critical point: the "ticks" returned by |
|
@efiring it's pretty late where I live so I wasn't able to contact the other team, I think I understand what you want me to do and I pushed a fix. |
| @@ -592,6 +597,7 @@ def _ticker(self): | |||
| formatter.set_data_interval(*intv) | |||
|
|
|||
| b = np.array(locator()) | |||
| self._tick_data_values = b | |||
There was a problem hiding this comment.
It looks like you are close, but shouldn't you save the b values after all potential modifications? See the following lines.
|
@efiring I made the changes. |
|
Thank you, @yongzhez! |
This is my proposed inclusion for #5792. I do note that it hands backs the ticks in a list instead of an array, is that a problem by any chance?