Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5998: Support fallback font correctly #6203

Merged
merged 2 commits into from Apr 12, 2016
Merged

Fix #5998: Support fallback font correctly #6203

merged 2 commits into from Apr 12, 2016

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Mar 21, 2016

Cc: @zblz

@mdboom mdboom added this to the 2.0 (style change major release) milestone Mar 21, 2016
@mdboom mdboom changed the title Fix #6015: Support fallback font correctly Fix #5998: Support fallback font correctly Mar 21, 2016
QuLogic
QuLogic reviewed Mar 22, 2016
View reviewed changes
lib/matplotlib/mathtext.py
@@ -887,12 +887,12 @@ class DejaVuFonts(UnicodeFonts):

def __init__(self, *args, **kwargs):
# This must come first so the backend's owner is set correctly
TruetypeFonts.__init__(self, *args, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment above still true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think it turned out that this move wasn't necessary after all -- I had meant to revert it before committing. I'll do so now.

@zblz
Copy link
Member

zblz commented Mar 23, 2016

Looks good to me! 👍

Do we have any idea why forcing an italics class was initially needed? Or was it just a bug?

@mdboom
Copy link
Member Author

mdboom commented Mar 23, 2016

In the context of STIX falling back to Bakoma, it needs to be hardcoded to it because the symbols the fallback was needed for are only in it. I think this was copied-and-pasted to the context of DejaVu falling back to STIX, where that is not the case.

@QuLogic
Copy link
Member

QuLogic commented Mar 26, 2016

Are there no italic numbers? 05 vs 15?

I also wonder what is wrong with the baseline of the 't'.

@mdboom
Copy link
Member Author

mdboom commented Apr 11, 2016

@QuLogic: That's correct. There are no italic circled numbers. Not sure what you mean by "05 vs. 15"

The baseline of t is a larger issue (addressed by #5414, but it will be some time to get that done). But that's not introduced by this PR.

@QuLogic
Copy link
Member

QuLogic commented Apr 11, 2016

@QuLogic: That's correct. There are no italic circled numbers. Not sure what you mean by "05 vs. 15"

No, I didn't mean circled, just plain italic numbers, e.g., mathfont_dejavusans_05.png vs. mathfont_dejavusans_15.png specify mathrm vs. mathit. But I see this is the case for the other fonts as well.

@mdboom
Copy link
Member Author

mdboom commented Apr 11, 2016

Yes -- there are no italic numbers in any of these fonts.

@mdboom
Copy link
Member Author

mdboom commented Apr 11, 2016

This is ready to merge.

@tacaswell tacaswell merged commit 0db1152 into matplotlib:master Apr 12, 2016
tacaswell added a commit that referenced this pull request Apr 12, 2016
@tacaswell
Merge pull request #6203 from mdboom/mathfonts
819f746 
Fix #5998: Support fallback font correctly
@tacaswell
Copy link
Member

backported to v2.x as 819f746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdboom @zblz @QuLogic @tacaswell