Fix sphinx 1.4.0 issues #6238
Merged
Fix sphinx 1.4.0 issues #6238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other parts of the code overwrites this with a list, fixes one sphinx warning with sphinx 1.4.0
Fixes sphinx warnings
Fix more sphinx warnings
|
We may want to backport this to 2.x or possibly 1.5.x? |
|
Fixes #6235 |
|
Seems ok to me, and it makes sense that they would be more strict about adding nodes and directives multiple times. |
tacaswell
added a commit
that referenced
this pull request
Mar 30, 2016
Fix sphinx 1.4.0 issues
Conflicts:
.travis.yml
Reject all changes
|
backported to v1.5.1-doc as 3a944a6 |
bearstrong
pushed a commit
to bearstrong/matplotlib
that referenced
this pull request
Apr 1, 2016
Fix sphinx 1.4.0 issues
Conflicts:
.travis.yml
Reject all changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the primary issues were that we added nodes and roles to the sphinx extensions multiple times. However, my understanding of the Sphinx extensions is not particularly great so I may be misunderstanding something.