Raise lock timeout as actual exception #6777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2577,10 +2577,11 @@ def _putmask(a, mask, values): | |||
| return np.copyto(a, values, where=mask) | |||
|
|
|||
| _lockstr = """\ | |||
| LOCKERROR: matplotlib is trying to acquire the lock {!r} | |||
| LOCKERROR: matplotlib is trying to acquire the lock | |||
| {!r} | |||
| and has failed. This maybe due to any other process holding this | |||
| lock. If you are sure no other matplotlib process in running try | |||
There was a problem hiding this comment.
Might as well fix it to say "is running", too.
|
also closes #6721 |
|
The 2.x branch still has the pickle code. |
|
@tacaswell: This still seems to backport cleanly and correctly to 2.x, despite the use of pickle rather than json... |
|
@tacaswell: I think this is ready for a final review. |
tacaswell
added a commit
that referenced
this pull request
Jul 25, 2016
Raise lock timeout as actual exception
|
So this still needs a backport? |
|
I backportd this to v2.x as e691c28 (but forgot to note it, sorry). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3655.
I haven't been able to directly reproduce #3655, so this is all based on theory, but given the symptoms and what we know about it, I'm reasonably certain about what is happening.
If a lock directory accidentally remains on disk in the
~/.cache/matplotlibdirectory from a previous run, it will wait around 90 seconds waiting for the lock to go away, and then timeout. When it times out, it simply tries again (once), and ultimately fails silently to write the file to disk.The solution here is to: