Fix Normalize(<signed integer array>). #6837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, everything needs to be cast to a float early enough.
|
Related to, but not part of this PR: |
|
Actually that was also broken by #6700. I fixed it now. |
anntzer
force-pushed
the
fix-integer-normalization
branch
from
1ec7c42
to
9d6f77e
Compare
anntzer
force-pushed
the
fix-integer-normalization
branch
from
9d6f77e
to
ac0c85a
Compare
tacaswell
added a commit
that referenced
this pull request
Aug 1, 2016
FIX: Normalize(<signed integer array>). closes #6825
|
backported to v2.x as 7e938fa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, everything needs to be cast to a float early enough.
See #6825, #6700 -- I've decided to use the whack-a-bug-at-a-time approach for now.