Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 807 auto minor locator #961

Merged
merged 1 commit into from Jun 30, 2012

Conversation

WeatherGod
Copy link
Member

Possible bugfix for issue #807.

@jdh2358
Copy link
Collaborator

jdh2358 commented Jun 30, 2012

I can duplicate the error in issue 807, but when I run with your patch, although it prevents the crash, I still get lots of warnings:

msierig@pinchiepie:~> python test.py
/home/msierig/dev/lib/python2.7/site-packages/matplotlib/ticker.py:1557: RuntimeWarning: divide by zero encountered in double_scalars
  tmin = np.ceil((vmin - t0) / minorstep) * minorstep
/home/msierig/dev/lib/python2.7/site-packages/matplotlib/ticker.py:1557: RuntimeWarning: invalid value encountered in double_scalars
  tmin = np.ceil((vmin - t0) / minorstep) * minorstep
/home/msierig/dev/lib/python2.7/site-packages/matplotlib/ticker.py:1558: RuntimeWarning: divide by zero encountered in double_scalars
  tmax = np.floor((vmax - t0) / minorstep) * minorstep
/home/msierig/dev/lib/python2.7/site-packages/matplotlib/ticker.py:1558: RuntimeWarning: invalid value encountered in double_scalars
  tmax = np.floor((vmax - t0) / minorstep) * minorstep

@jdh2358
Copy link
Collaborator

jdh2358 commented Jun 30, 2012

I'm going to merge this now because it is an improvement over what we have and it fixes a legitimate bug. There may be better solutions out there but we can clean later. I need to get 1.1.1 out today for the debian release freeze so I am going to include this.

jdh2358 added a commit that referenced this pull request Jun 30, 2012
@jdh2358 jdh2358 merged commit 7e47149 into matplotlib:v1.1.x Jun 30, 2012
@WeatherGod WeatherGod deleted the issue-807-AutoMinorLocator branch July 23, 2014 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants