Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/_matrix/key/v2/server says it's signed by "the verify keys", but which ones from the list should be used? #1726

Open
turt2live opened this issue Feb 15, 2024 · 1 comment
Open

/_matrix/key/v2/server says it's signed by "the verify keys", but which ones from the list should be used? #1726

turt2live opened this issue Feb 15, 2024 · 1 comment
Labels
A-S2S Server-to-Server API (federation) clarification An area where the expected behaviour is understood, but the spec could do with being more explicit good first issue This is a fix that might be an easy place for someone to start for their first contribution

Comments

@turt2live
Copy link
Member

Link to problem area: https://spec.matrix.org/v1.9/server-server-api/#get_matrixkeyv2server

Issue
I believe all of the verify_keys need to sign the object, but it's not impossible that we only require one.

Related: #510
@turt2live turt2live added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit A-S2S Server-to-Server API (federation) labels Feb 15, 2024
@turt2live turt2live mentioned this issue Feb 15, 2024
Draft
3 tasks
@richvdh
Copy link
Member

richvdh commented Feb 15, 2024

Synapse appears to only require one.

https://github.com/element-hq/synapse/blob/v1.101.0/synapse/crypto/keyring.py#L571-L590

@richvdh richvdh added the good first issue This is a fix that might be an easy place for someone to start for their first contribution label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-S2S Server-to-Server API (federation) clarification An area where the expected behaviour is understood, but the spec could do with being more explicit good first issue This is a fix that might be an easy place for someone to start for their first contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @richvdh