Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: No card delete confirmation status for some cards #4476

Open
harshilsharma63 opened this issue Jan 17, 2023 · 3 comments · Fixed by Kuuchuu/focalboard#13 · May be fixed by #4612
Open

Bug: No card delete confirmation status for some cards #4476

harshilsharma63 opened this issue Jan 17, 2023 · 3 comments · Fixed by Kuuchuu/focalboard#13 · May be fixed by #4612
Assignees
@JesusMurguia
Labels
Bug Something isn't working Help Wanted Extra attention is needed QA Verified Bug fix tested and verified by QA

Comments

@harshilsharma63
Copy link
Member

Steps to reproduce the behavior

  1. Create a new card. Add some properties to it and set their values. Add some comments in there as well. Do not set the card title.
  2. Go back to kanban view and try deleting the card.
  3. Notice the UI didn't show any delete confirmation for this card.
  4. Create a new card and repeat step 1 but this time also set a card title.
  5. Go back to kanban view and try deleting the card. Notice that this time you see a delete confirmation.

Expected behavior

Card delete confirmation should show up if there is any data in the card.

Edition and Platform

  • Edition: Mattermost Boards (plugin)
  • Version: v7.8.0
  • Browser and OS: Firefox on MacOS

Additional context

The log in webapp is probably if the card has no title and no content, don't show the delete confirmation dialogue. It does not take into consideration the properties and comments in the card.
@harshilsharma63 harshilsharma63 added Triage Bug Something isn't working labels Jan 17, 2023
@wuwinson
Copy link
Contributor

Agreed, we should display the deletion confirmation if there is any content on the card - title, properties, comments, card description (content).

@wuwinson wuwinson added Help Wanted Extra attention is needed Up for grabs Looking for a contributor to fix it and removed Triage labels Jan 17, 2023
@wuwinson wuwinson mentioned this issue Jan 17, 2023
Open
@JesusMurguia
Copy link

I would like to work on this.

@wuwinson
Copy link
Contributor

wuwinson commented Mar 1, 2023

Awesome, thanks @JesusMurguia! Assigned to you. cc @sbishel

@JesusMurguia JesusMurguia linked a pull request Mar 2, 2023 that will close this issue
Open
@lindy65 lindy65 added QA Verified Bug fix tested and verified by QA and removed Up for grabs Looking for a contributor to fix it labels Mar 13, 2023
mattermost-build added a commit to JesusMurguia/focalboard that referenced this issue Mar 29, 2023
@mattermost-build
Merge branch 'main' into mattermostGH-4476-No-card-delete-confirmatio…
ef31f87 
…n-status
stypr added a commit to stypr/focalboard that referenced this issue Sep 29, 2023
@stypr
[mattermostGH-4476] Bug: No card delete confirmation status for some…
b087eec 
… cards mattermost#4612
@Kuuchuu Kuuchuu mentioned this issue May 9, 2024
Merged
Kuuchuu added a commit to Kuuchuu/focalboard that referenced this issue May 9, 2024
@Kuuchuu
Merge pull request #13 from JesusMurguia/mattermostGH-4476-No-card-de…
a10abae 
…lete-confirmation-status

Gh 4476 no card delete confirmation status
@Kuuchuu Kuuchuu mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JesusMurguia JesusMurguia

Labels
Bug Something isn't working Help Wanted Extra attention is needed QA Verified Bug fix tested and verified by QA
Projects
None yet
Milestone
No milestone
4 participants
@lindy65 @harshilsharma63 @JesusMurguia @wuwinson