Merge pull request #70 from radford/avoid-nil-remove

Avoid trying to remove properties that don't exist now that errors are thrown/checked
maxdemarzi · Nov 28, 2012 · 14d469e · 14d469e
2 parents a9687eb + a20d6b5
commit 14d469e
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/lib/neography/property.rb b/lib/neography/property.rb
@@ -11,10 +11,12 @@ def []=(key, value)
       key = key.to_sym
       k_str = key.to_s
       if value.nil?
-        if self.is_a? Neography::Node
-          neo_server.remove_node_properties(self.neo_id, [k_str])
-        else
-          neo_server.remove_relationship_properties(self.neo_id, [k_str])
+        unless @table[key].nil?
+          if self.is_a? Neography::Node
+            neo_server.remove_node_properties(self.neo_id, [k_str])
+          else
+            neo_server.remove_relationship_properties(self.neo_id, [k_str])
+          end
         end
       else
         if self.is_a? Neography::Node
@@ -33,7 +35,6 @@ def new_ostruct_member(name)
         meta = class << self; self; end
         meta.send(:define_method, name) { @table[name] }
         meta.send(:define_method, "#{name}=") do |value|
-          @table[name] = value
           self[name.to_sym] = value
         end
       end