fix for issue when setting nonexistent property for the first time using dot notation #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otation has no effect on the DB
maxdemarzi
added a commit
that referenced
this pull request
Apr 5, 2012
fix for issue when setting nonexistent property for the first time using dot notation
|
Thanks Dan! |
willkessler
pushed a commit
to willkessler/neography
that referenced
this pull request
Apr 21, 2014
start_node for in directions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you use dot notation to set a property on a node for the first time, like this:
It won't work. This is due to a bug in the implementation of method_missing in the Property module. This commit contains a fix along with an accompanying spec to illustrate the original problem.