Load Languages from Wikidata #111
Conversation
Its exported currently so removing it would be a breaking change. This method can not make any type guarantees other than string. So fix the types but dont remove it.
removing it would be breaking which this shouldnt be. Mark it as deprecated to be removed with the next major release.
|
hm… maybe the type I'm not sure if the But when thinking further this library is generic to Wikibase. The languages are specific to Wikimedia or Wikidata. So other Wikibase instances could have their independent set of languages. Which would mean that the language shouldn't be a specific type at all and rather a Exporting the list / type would still be useful. Maybe it's even a future thing to have a generic language type and |
|
wikidata-lang provides way more language information. Not sure if wikibase-sdk should contain the basic Wikidata information too? |
Conflicts: package.json tests/sitelinks_helpers.ts
+1 for |
|
Having a hard coded language shortlist was a nice to have from the time this lib was wikidata specific, but it doesn't provide that much value, from what I can gather: let's try |
|
superseded by #120 |
currently WmLanguageCode is based on the sites. I updated the scripts to load both the sites and the languages from Wikidata. As Wikidata probably knows all the languages from other Wikimedia projects it seems like a good source of languages for me.
I also changed some code related to languages and removed the
shortLangmethod. The shortLang reduced the options usable for methods like getEntities as you couldn’t specifyde-chearlier as it was automatically reduced tode. This seems like a bug to me but I might miss something?All the test cases still work except one which I think was a bug:
getSitelinkData().langincluded _ which only sites include. The language like it’s used in URLs and the lang arguments uses the -. The getSitelinkUrl also depends on it so I think this was another bug and the test case was also wrong.Fixes #107
Uses a helper from #106 so it should be merged first. Only the last commit is unique to this PR.