Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for screenshots #333

Open
rwmitchell opened this issue Aug 27, 2021 · 8 comments
Open

Suggestion for screenshots #333

rwmitchell opened this issue Aug 27, 2021 · 8 comments

Comments

@rwmitchell
Copy link

Recently came across

https://mayccoll.github.io/Gogh/

The two rows of color boxes at the top of each screenshot is really helpful (to me) for determining scheme I'm likely to like. It is much easier to differentiate near colors and which ones repeat and/or use the same color for bold and normal.

@mbadolato
Copy link
Owner

That's pretty nice, but would be a lot of effort to replace all of the current screenshots. Unless it could be automated somehow

@jdhmtl
Copy link
Collaborator

jdhmtl commented Sep 29, 2021

I'll echo what @rwmitchell said; seeing the text colours against the background color is generally more useful to me than the screenshots themselves.

I'm sure it could be automated easily enough. We're already running a number of transforms when we run update_all, which retrieve the hex values for the colours. Similar to what Gogh has done, we could store these in JSON within the repo and have the website consume that, then iterate over it to populate React components or similar. Happy to take a stab at it. Thoughts?

@mbadolato
Copy link
Owner

Sure!

@jdhmtl
Copy link
Collaborator

jdhmtl commented Aug 5, 2022

Took me forever to find the time to actually work on this, but here's a proof of concept. I can add a little polish if this looks worth having.

@mbadolato
Copy link
Owner

Looks great!

@ptere
Copy link

ptere commented Aug 15, 2022

🤩 Stellar work @jdhmtl! Been looking for something like this for a long time.

@antenore
Copy link
Contributor

Took me forever to find the time to actually work on this, but here's a proof of concept. I can add a little polish if this looks worth having.

That's
A
W
E
S
O
M
E

@joshka
Copy link
Contributor

joshka commented Sep 23, 2023

For those looking for it later, gogh is now at https://gogh-co.github.io/Gogh/ and https://github.com/Gogh-Co/Gogh

I wrote a small example for a rust crate I maintain (Ratatui) that could also be useful for showing colors for screenshots nicely (the color names are the ones used by the library - so subtly different to the ones used here):

image

to run this (assuming you have rust and github cli installed):

gh repo clone ratatui-org/ratatui
cd ratatui
cargo run --example colors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants